Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade textual #12

Merged
merged 11 commits into from
Sep 2, 2024
Merged

Conversation

mvassilev
Copy link
Collaborator

@mvassilev mvassilev commented Sep 1, 2024

  • Upgraded Textual with the latest version (0.78.0)
  • Diff areas are scrollable (the upgrade facilitated this change)
  • Code clean up

Fixes #7

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline suggestion. I find the terminology base vs regressed a little confusing as well as command. Maybe left/right, broken/working is clearer.

Looks reasonable. Consider squashing on merge.

Comment on lines +40 to +41
#executable_path1 = DiffArea(title="base executable and arguments", value="")
#executable_path2 = DiffArea(title="regression executable and arguments", value="")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#executable_path1 = DiffArea(title="base executable and arguments", value="")
#executable_path2 = DiffArea(title="regression executable and arguments", value="")

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this may be fixed as a new PR.

@mvassilev mvassilev merged commit 28aeb06 into compiler-research:main Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The textual_inputs dependency is no langer maintained
2 participants