-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade textual #12
Upgrade textual #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline suggestion. I find the terminology base
vs regressed
a little confusing as well as command
. Maybe left/right
, broken/working
is clearer.
Looks reasonable. Consider squashing on merge.
#executable_path1 = DiffArea(title="base executable and arguments", value="") | ||
#executable_path2 = DiffArea(title="regression executable and arguments", value="") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#executable_path1 = DiffArea(title="base executable and arguments", value="") | |
#executable_path2 = DiffArea(title="regression executable and arguments", value="") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this may be fixed as a new PR.
Fixes #7