-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Update recipe to version 34.1.1 #56
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Uses a bootstap version of pip to run the bootstrap.py script
Remove mocking of pip package as this is no longer needed.
setuptools 34.x.x removed the vendored dependencies which requires that they be installed separately. With 34.1.1 this can be done without pip. There is still a bit of an issue with circular dependencies as |
Should we build the last release of 33 first? Any other actions we need to take with the dependencies? |
I have no opinion on if a 33.1.1 release is needed. The changes for that release do not seem too major to warrent a seperate issue.
I do not believe so. Since we already have |
Side note: Issue ( pypa/setuptools#980 ) looks to be of interest. |
- certifi | ||
- packaging | ||
- six |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can't avoid having these as build dependencies too, right?
Merged with |
Would really appreciate if some people took a look at and chimed in on issue ( pypa/setuptools#980 ). The future of cc @conda-forge/core @conda-forge/setuptools @mingwandroid |
Thanks for the info @jakirkham, my only comment here is to say that being able to bootstrap an entire distribution is extremely important and that when dependencies end up cyclic that is no longer possible. Is my reading of the situation close to the mark? If it is of any use as a data-point, I have successfully bootstrapped a cross-compiled Miniconda-like distribution based on If there's anything I can do to help this situation then please let me know. Using pre-built binaries is not possible when bootstrapping for a new platform. |
Sorry, but I really don't have anything useful to contribute (read the issue you referenced, at least until my eyes glazed over). |
Yikes, that's a mess. Not sure what I can do but happy to help. |
Superseded by #66 |
No description provided.