Convert Products to Minion

[niklasdewally]

This PR converts Product expressions to Minion. Continuation of #563, which added the Product expression and its normalising rules.

• rules/minion: flatten Leq,Geq,Lt,Gt using flatten_binop
• rules: add remove_unit_vector_product
• Add FlatProductEq and Minion conversion rules

---

[ozgurakgun]

looks good though I think you'll have to rebase due to the changes I made in #568

[ozgurakgun]

better if we wait until all tests pass before merging...

[niklasdewally]

better if we wait until all tests pass before merging...

apologies - sausage fingers!

[niklasdewally]

@ozgurakgun It might be helpful (for my weird workflow at least) if we could have auto-deleting branches on merge, and automerge on passing tests:

• https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/automatically-merging-a-pull-request

• https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-the-automatic-deletion-of-branches

[ozgurakgun]

I enabled auto-deletion, no arguments against this.

I am also happy to configure auto-merge once reviewed&approved + all tests pass. Not sure how to do this however.

Also, I am not sure what the benefit is. It takes away some flexibility in the order of merging.

[niklasdewally]

I enabled auto-deletion, no arguments against this.

Thanks

I am also happy to configure auto-merge once reviewed&approved + all tests pass. Not sure how to do this however.

Also, I am not sure what the benefit is. It takes away some flexibility in the order of merging.

It is not fully automatic: what it does is give you a button to "enable auto merge" on a specific PR, and then when checks pass on that PR, it will merge itself into main.

My minor annoyance is having to keep checking Github to see if my PR has finished its checks yet before merging it, or accidentally clicking merge too early.

From the docs, it looks like we need the "require checks to pass" branch restriction. As repo admin, it looks like you can override these for a PR if needed, so it mainly affects me