fix(parser/json): JSON parser failing on explicit matrix index domains #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Add an edge case for domain parsing in the JSON parser, fixing the parsing of explicit matrix index domains. This fixes test basic/matrix/04-value-letting. + Do not run `remove_empty` on `AbstractLiteral` expressions.
|
Apologies, I seemed to miss this incorrect test output when checking the previous PR. |
Code and Documentation Coverage ReportDocumentation CoverageThis PR: conjure_core: 3% with examples, 54% documented -- 8/153/296 Main: conjure_core: 3% with examples, 54% documented -- 8/153/296 View full documentation coverage for main, this PR Code Coverage SummaryThis PR: Detailed Report Main: Detailed Report Coverage Main & PR Coverage ChangeFunctions coverage changed by 0.00% and covered lines changed by 1
Branches... coverage: No comparison data available |
This was referenced Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an edge case for domain parsing in the JSON parser, fixing the parsing of explicit matrix index domains. This fixes test basic/matrix/05-value-letting-index
Do not run
remove_emptyonAbstractLiteralexpressions.