feat(node): default executor finish message with hook #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptoAtwill
changed the title
cryptoAtwill
changed the title
drahnr
reviewed
Feb 24, 2025
fvm/src/executor/default.rs
Outdated
|
|
||
| if (&base_fee_burn + &over_estimation_burn + &refund + &miner_tip) != gas_cost { | ||
| if gas_sum != gas_cost { | ||
| // Sanity check. This could be a fatal error. | ||
| return Err(anyhow!("Gas handling math is wrong")); |
There was a problem hiding this comment.
Please provide more context and use the bail! macro
drahnr
reviewed
Feb 24, 2025
drahnr
reviewed
Feb 24, 2025
drahnr
reviewed
Feb 24, 2025
drahnr
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
finish_message_with_hookmethod that allows customisation on which actors receives the transaction gas fee, i.e.ref-fvm/fvm/src/executor/default.rs
Line 528 in 579946f
This is implemented by introducing a gas processing hook with a newly added method: execute_with_options. This method takes a closure as the gas processing hook. At the end of the execution, finish_message is replaced with finish_message_with_hook instead that calls the hook.