Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize the log file to fix nerdctl compose up error #1132

Merged
merged 4 commits into from
Jun 18, 2022

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Jun 17, 2022

Fix #1071

Also contains refactoring in a separate commit

@AkihiroSuda AkihiroSuda added this to the v0.20.1 milestone Jun 17, 2022
@AkihiroSuda AkihiroSuda requested a review from a team June 17, 2022 14:49
@AkihiroSuda
Copy link
Member Author

Will release the new version after merging this

Copy link
Member

@junnplus junnplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

To make sure that the logging drivers appear in the `nerdctl info` output

Signed-off-by: Akihiro Suda <[email protected]>
Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda merged commit 99b12dd into containerd:master Jun 18, 2022
ningmingxiao pushed a commit to ningmingxiao/nerdctl that referenced this pull request Jun 18, 2022
Initialize the log file to fix `nerdctl compose up` error

Signed-off-by: ningmingxiao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running nerdctl compose up immediately exists with "no such file or directory" on -json.log file
3 participants