Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exclude default bridge network in network prune #1304

Merged
merged 1 commit into from
Aug 13, 2022
Merged

exclude default bridge network in network prune #1304

merged 1 commit into from
Aug 13, 2022

Conversation

tal66
Copy link
Contributor

@tal66 tal66 commented Aug 8, 2022

Hi, this should fix #1295
(nerdctl network prune does not need to remove the default bridge network)

@manugupt1
Copy link
Contributor

Please sign off with real name.

@fahedouch
Copy link
Member

fahedouch commented Aug 9, 2022 •
edited
Loading

plz use DefaultNetworkDriver const from package main so we avoid deleting bridge for unix and nat for windows
see #1279 (comment)

@junnplus junnplus added the status/needs-DCO-sign Needs DCO sign (the “Signed-off-by” in the commit message) label Aug 10, 2022
fahedouch
fahedouch requested changes Aug 11, 2022
View reviewed changes
@fahedouch
Copy link
Member

Thanks, but please squash your commits and sign the commit for DCO
https://github.com/apps/dco

(run git commit -a -s --amend, and make sure that the Signed-off-by: NAME <EMAIL> line with your real name is included in the commit message)

junnplus
junnplus suggested changes Aug 13, 2022
View reviewed changes
@AkihiroSuda AkihiroSuda removed the status/needs-DCO-sign Needs DCO sign (the “Signed-off-by” in the commit message) label Aug 13, 2022
@AkihiroSuda AkihiroSuda added this to the v0.22.3 milestone Aug 13, 2022
AkihiroSuda
AkihiroSuda approved these changes Aug 13, 2022
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit a11a9fd into containerd:master Aug 13, 2022
@yardenshoham yardenshoham mentioned this pull request Sep 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manugupt1 manugupt1 manugupt1 left review comments

@fahedouch fahedouch fahedouch requested changes

@junnplus junnplus junnplus requested changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging this pull request may close these issues.

nerdctl network prune does not need to remove the default bridge network
5 participants
@tal66 @manugupt1 @fahedouch @junnplus @AkihiroSuda