-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support filter argument for nerdctl images
command
#1307
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bd190d8
to
c84e71c
Compare
AkihiroSuda
reviewed
Aug 16, 2022
c84e71c
to
07932e3
Compare
manugupt1
reviewed
Aug 17, 2022
manugupt1
reviewed
Aug 17, 2022
afac094
to
8f50e07
Compare
AkihiroSuda
reviewed
Aug 17, 2022
manugupt1
reviewed
Aug 18, 2022
8f50e07
to
2b43c9a
Compare
fahedouch
reviewed
Aug 18, 2022
2b43c9a
to
a776ce2
Compare
Windows CI is failing
|
a776ce2
to
6ed7c6f
Compare
6ed7c6f
to
3874331
Compare
Signed-off-by: Zheao.Li <[email protected]>
3874331
to
4929d19
Compare
fahedouch
approved these changes
Aug 19, 2022
manugupt1
approved these changes
Aug 20, 2022
AkihiroSuda
reviewed
Aug 20, 2022
buildCtx, err := createBuildContext(dockerfile) | ||
assert.NilError(t, err) | ||
defer os.RemoveAll(buildCtx) | ||
base.Cmd("build", "-t", tempName, "-f", buildCtx+"/Dockerfile", buildCtx).AssertOK() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need this -f
AkihiroSuda
approved these changes
Aug 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1283
Signed-off-by: Zheao.Li [email protected]