Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support filter argument for nerdctl images command #1307

Merged
merged 1 commit into from
Aug 20, 2022

Conversation

Zheaoli
Copy link
Member

@Zheaoli Zheaoli commented Aug 9, 2022

Fix #1283

Signed-off-by: Zheao.Li [email protected]

@Zheaoli Zheaoli marked this pull request as draft August 9, 2022 15:10
@Zheaoli Zheaoli force-pushed the manjusaka/support-1283 branch 2 times, most recently from bd190d8 to c84e71c Compare August 16, 2022 14:41
@Zheaoli Zheaoli marked this pull request as ready for review August 16, 2022 15:02
@Zheaoli Zheaoli requested review from AkihiroSuda, junnplus and fahedouch and removed request for AkihiroSuda and junnplus August 16, 2022 15:04
@Zheaoli Zheaoli force-pushed the manjusaka/support-1283 branch from c84e71c to 07932e3 Compare August 16, 2022 15:19
@Zheaoli Zheaoli requested a review from AkihiroSuda August 16, 2022 15:19
@AkihiroSuda AkihiroSuda added this to the v0.22.3 milestone Aug 17, 2022
@Zheaoli Zheaoli force-pushed the manjusaka/support-1283 branch 4 times, most recently from afac094 to 8f50e07 Compare August 17, 2022 15:05
@Zheaoli Zheaoli force-pushed the manjusaka/support-1283 branch from 8f50e07 to 2b43c9a Compare August 18, 2022 08:03
@Zheaoli Zheaoli force-pushed the manjusaka/support-1283 branch from 2b43c9a to a776ce2 Compare August 18, 2022 12:39
@AkihiroSuda
Copy link
Member

Windows CI is failing

=== CONT  TestImagesFilter
    images_test.go:91: assertion failed: res.ExitCode is not exitCode: time="2022-08-18T18:39:55Z" level=warning msg="environment variable XDG_RUNTIME_DIR is not set, see https://rootlesscontaine.rs/getting-started/common/login/"
        time="2022-08-18T18:39:55Z" level=error msg="`buildctl` needs to be installed and `buildkitd` needs to be running, see https://github.com/moby/buildkit , and `containerd-rootless-setuptool.sh install-buildkit` for OCI worker or `containerd-rootless-setuptool.sh install-buildkit-containerd` for containerd worker" error="3 errors occurred:\n\t* failed to ping to host unix://\\run\\user\\-1\\buildkit-nerdctl-test\\buildkitd.sock: only linux is supported\n\t* failed to ping to host unix://\\run\\user\\-1\\buildkit-default\\buildkitd.sock: only linux is supported\n\t* failed to ping to host unix://\\run\\user\\-1\\buildkit\\buildkitd.sock: only linux is supported\n\n"
        time="2022-08-18T18:39:55Z" level=fatal msg="no buildkit host is available, tried 3 candidates: 3 errors occurred:\n\t* failed to ping to host unix://\\run\\user\\-1\\buildkit-nerdctl-test\\buildkitd.sock: only linux is supported\n\t* failed to ping to host unix://\\run\\user\\-1\\buildkit-default\\buildkitd.sock: only linux is supported\n\t* failed to ping to host unix://\\run\\user\\-1\\buildkit\\buildkitd.sock: only linux is supported\n\n"
--- FAIL: TestImagesFilter (1.87s)

https://cirrus-ci.com/task/4824472178917376

@Zheaoli Zheaoli force-pushed the manjusaka/support-1283 branch from a776ce2 to 6ed7c6f Compare August 19, 2022 04:27
@Zheaoli Zheaoli requested review from manugupt1 and removed request for manugupt1 August 19, 2022 13:36
@Zheaoli Zheaoli requested review from AkihiroSuda, manugupt1 and fahedouch and removed request for manugupt1 August 19, 2022 13:36
@Zheaoli Zheaoli force-pushed the manjusaka/support-1283 branch from 6ed7c6f to 3874331 Compare August 19, 2022 13:39
@Zheaoli Zheaoli force-pushed the manjusaka/support-1283 branch from 3874331 to 4929d19 Compare August 19, 2022 14:17
@Zheaoli Zheaoli requested a review from manugupt1 August 19, 2022 15:01
buildCtx, err := createBuildContext(dockerfile)
assert.NilError(t, err)
defer os.RemoveAll(buildCtx)
base.Cmd("build", "-t", tempName, "-f", buildCtx+"/Dockerfile", buildCtx).AssertOK()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need this -f

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit bec8ebf into containerd:master Aug 20, 2022
@Zheaoli Zheaoli deleted the manjusaka/support-1283 branch August 20, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support filters argument in images command
4 participants