Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipfs: allow configuring ipfs daemon address #1801

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

ktock
Copy link
Member

@ktock ktock commented Jan 4, 2023

Fixes #1781
Depends on containerd/stargz-snapshotter#1050

This commit adds --ipfs-address flag to nerdctl pull, nerdctl run, nerdctl compose.
This allows nerdctl to use an arbitrary IPFS API address instead of the local daemon, as proposed in #1781 .

@ktock ktock marked this pull request as ready for review January 10, 2023 02:18
@AkihiroSuda AkihiroSuda added the area/ipfs IPFS label Jan 10, 2023
@AkihiroSuda AkihiroSuda added this to the v1.2.0 milestone Jan 10, 2023
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda
Copy link
Member

Needs rebase

@AkihiroSuda AkihiroSuda merged commit 05d0eb5 into containerd:main Jan 11, 2023
@ktock ktock deleted the ipfspulladdress branch January 11, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --ipfs-address to nerdctl pull
2 participants