Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make prune to remove dangling images only #1935

Merged
merged 1 commit into from
Feb 16, 2023
Merged

make prune to remove dangling images only #1935

merged 1 commit into from
Feb 16, 2023

Conversation

suyanhanx
Copy link
Contributor

@suyanhanx suyanhanx commented Jan 27, 2023 •
edited
Loading

@suyanhanx suyanhanx mentioned this pull request Jan 27, 2023
Merged
manugupt1
manugupt1 reviewed Jan 27, 2023
View reviewed changes
@suyanhanx suyanhanx force-pushed the 1922 branch 2 times, most recently from 41ee715 to e0a688b Compare January 28, 2023 12:30
@suyanhanx suyanhanx marked this pull request as ready for review January 28, 2023 14:20
@suyanhanx
Copy link
Contributor Author

@djdongjin PTAL, thanks.

djdongjin
djdongjin approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@djdongjin djdongjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@suyanhanx suyanhanx force-pushed the 1922 branch 3 times, most recently from d1e5073 to 46677e3 Compare February 7, 2023 12:10
djdongjin
djdongjin reviewed Feb 7, 2023
View reviewed changes
djdongjin
djdongjin approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@djdongjin djdongjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@fahedouch fahedouch added this to the v1.3.0 (tentative) milestone Feb 8, 2023
manugupt1
manugupt1 reviewed Feb 15, 2023
View reviewed changes
Copy link
Contributor

@manugupt1 manugupt1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after replacing Run with AssertOk

@suyanhanx suyanhanx force-pushed the 1922 branch 2 times, most recently from 651f1d5 to ea5fa89 Compare February 15, 2023 07:08
@suyanhanx suyanhanx requested a review from manugupt1 February 15, 2023 07:11
@manugupt1 manugupt1 requested a review from a team February 15, 2023 07:50
AkihiroSuda
AkihiroSuda approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit bb7bba5 into containerd:main Feb 16, 2023
@suyanhanx suyanhanx deleted the 1922 branch February 16, 2023 05:55
@suyanhanx suyanhanx mentioned this pull request Feb 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manugupt1 manugupt1 manugupt1 approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@djdongjin djdongjin djdongjin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.1
Development

Successfully merging this pull request may close these issues.

Make image prune remove dangling images by default
5 participants
@suyanhanx @manugupt1 @AkihiroSuda @djdongjin @fahedouch