feat: add network in use check to compose down
#1938
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add an integration test for this scenario? |
I may try~ |
Retrospection
added a commit
to Retrospection/nerdctl
that referenced
this pull request
Feb 9, 2023
Retrospection
added a commit
to Retrospection/nerdctl
that referenced
this pull request
Feb 9, 2023
Signed-off-by: Retros <[email protected]>
Retrospection
added a commit
to Retrospection/nerdctl
that referenced
this pull request
Feb 11, 2023
Signed-off-by: Retros <[email protected]>
Retrospection
force-pushed
the
master
branch
from
1e1e873 to
b0e20fd
Compare
fahedouch
requested changes
Feb 15, 2023
fahedouch
reviewed
Feb 15, 2023
Please use a real name, as explained in cncf/foundation#383 (comment) |
Retrospection
force-pushed
the
master
branch
3 times, most recently
from
7732e5a to
c878de2
Compare
|
Please also update your DCO sign in the PR description and squash your commits. |
suyanhanx
reviewed
Feb 23, 2023
| t.Logf("projectName=%q", projectName) | ||
|
|
||
| base.ComposeCmd("-p", projectName, "-f", compFull.YAMLFullPath(), "up", "-d").AssertOK() | ||
| base.ComposeCmd("-p", projectName, "-f", compOrphan.YAMLFullPath(), "down", "-v").AssertCombinedOutContains("is in use") |
There was a problem hiding this comment.
Need to clean up the orphan container and related network.
defer base.ComposeCmd("-p", projectName, "-f", compFull.YAMLFullPath(), "down", "--remove-orphans").AssertOK()
Retrospection
force-pushed
the
master
branch
from
c878de2 to
b0701ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YuRuosheng [email protected]
Close #1425