Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[carry #2337] ensure logger completion after container exit #3995

Merged

Conversation

fahedouch
Copy link
Member

@fahedouch fahedouch commented Mar 6, 2025

carry #2337

Introduced mechanisms to ensure logger completion after container exit using file locks and added robust handling for log streams.

@fahedouch fahedouch marked this pull request as draft March 6, 2025 14:18
@fahedouch fahedouch changed the title [carry #2337] Add logger synchronization and enhance logging functionality [carry #2337] ensure logger completion after container exit Mar 6, 2025
@fahedouch fahedouch force-pushed the carry-shutdown-logger-after-exits branch 3 times, most recently from bade684 to ebb0bcf Compare March 8, 2025 21:54
Introduced mechanisms to ensure logger completion after container exit using file locks and added robust handling for log streams. Updated and added tests to validate functionality, including log behavior with running, non-terminated, and restarted containers.

Signed-off-by: fahed dorgaa <[email protected]>
@fahedouch fahedouch force-pushed the carry-shutdown-logger-after-exits branch from ebb0bcf to 27b91ec Compare March 8, 2025 21:59
@fahedouch fahedouch marked this pull request as ready for review March 8, 2025 22:00
@AkihiroSuda AkihiroSuda added this to the v2.0.4 milestone Mar 10, 2025
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 7df4f3d into containerd:main Mar 10, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants