imageproxy: Add a method to get image configuration #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends containers/skopeo#1523 |
cgwalters
force-pushed
the
proxy-config
branch
2 times, most recently
from
2c5eb22 to
a639a65
Compare
|
OK, I've updated this 🆕 with infrastructure to support runtime matching of the semver, moving new API methods to a new struct. |
We need this for a few reasons: - It has the layer ordering, which we are *currently* ignoring but will probably be important for correctness later - It is the only thing that has extensible metadata that will survive round trips through docker schema 2
cgwalters
force-pushed
the
proxy-config
branch
from
a639a65 to
341a3b3
Compare
|
Tested in concert with ostreedev/ostree-rs-ext#176 |
|
My OCD didn't allow having a runtime |
jlebon
reviewed
Dec 8, 2021
|
|
||
| Ok(r) | ||
| } | ||
|
|
||
| /// If the proxy supports at least semver 0.2.3, return a wrapper with methods from that version. |
There was a problem hiding this comment.
Interesting approach. I can imagine this becoming unwieldy if we have lots of different versions we need to expose. But I guess clients are coupled enough that we can ensure there's not a large skew to maintain.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this for a few reasons:
but will probably be important for correctness later
survive round trips through docker schema 2