Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Check for IsNotExists #15913

Closed
cevich opened this issue Sep 23, 2022 · 0 comments · Fixed by #15917
Closed

CI: Check for IsNotExists #15913

cevich opened this issue Sep 23, 2022 · 0 comments · Fixed by #15917
Assignees
@cevich
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@cevich
Copy link
Member

cevich commented Sep 23, 2022

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind feature

Description

CI Should check for os.IsNotExists(err) versus the recommended errors.Is(err, os.ErrNotExist)

Steps to reproduce the issue:

  1. Run CI having added/renamed/updated code that uses os.IsNotExists(err)

Describe the results you received:

CI Passes

Describe the results you expected:

CI Should fail early with a recommendation to use errors.Is(err, os.ErrNotExist)

Additional information you deem important (e.g. issue happens only occasionally):

Ref: #15893 (comment)

Output of podman version:

N/A

Output of podman info:

N/A

Package info (e.g. output of rpm -q podman or apt list podman):

N/A

Have you tested with the latest version of Podman and have you checked the Podman Troubleshooting Guide? (https://github.com/containers/podman/blob/main/troubleshooting.md)

Yes

Additional environment details (AWS, VirtualBox, physical, etc.):

N/A
@openshift-ci openshift-ci bot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 23, 2022
@cevich cevich self-assigned this Sep 23, 2022
@cevich cevich mentioned this issue Sep 23, 2022
Merged
cevich added a commit to cevich/podman that referenced this issue Sep 26, 2022
@cevich
Cirrus: Add golang code consistency check script
527fc40 
Depends on containers#15893

Fixes: containers#15913

Signed-off-by: Chris Evich <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cevich cevich

Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CI:BUILD] Check new go code cevich/podman
1 participant
@cevich