Skip to content

Commit

Permalink
Fix broadcast message order
Browse files Browse the repository at this point in the history
  • Loading branch information
contrun committed Jan 1, 2025
1 parent 8ca34e0 commit ea5c1fe
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
4 changes: 4 additions & 0 deletions src/fiber/gossip.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1031,6 +1031,10 @@ impl<S: GossipMessageStore> ExtendedGossipMessageStoreState<S> {

let mut sorted_messages = complete_messages.into_iter().collect::<Vec<_>>();
sorted_messages.sort_unstable();
trace!(
"Saving complete messages to the store: {:?}",
&sorted_messages
);

let mut verified_sorted_messages = Vec::with_capacity(sorted_messages.len());
for message in sorted_messages {
Expand Down
8 changes: 4 additions & 4 deletions src/fiber/types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2615,14 +2615,14 @@ impl Ord for BroadcastMessageID {
BroadcastMessageID::NodeAnnouncement(pubkey1),
BroadcastMessageID::NodeAnnouncement(pubkey2),
) => pubkey1.cmp(pubkey2),
(BroadcastMessageID::ChannelUpdate(_), _) => Ordering::Less,
(BroadcastMessageID::NodeAnnouncement(_), _) => Ordering::Greater,
(BroadcastMessageID::NodeAnnouncement(_), _) => Ordering::Less,
(BroadcastMessageID::ChannelUpdate(_), _) => Ordering::Greater,
(
BroadcastMessageID::ChannelAnnouncement(_),
BroadcastMessageID::NodeAnnouncement(_),
) => Ordering::Less,
) => Ordering::Greater,
(BroadcastMessageID::ChannelAnnouncement(_), BroadcastMessageID::ChannelUpdate(_)) => {
Ordering::Greater
Ordering::Less
}
}
}
Expand Down

0 comments on commit ea5c1fe

Please sign in to comment.