-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to lint all commits in a PR? #12
Comments
conventional-changelog-lint --from=HEAD~$(git --no-pager rev-list master..HEAD --count) another way to do it. |
|
Why not just Answering myself: Because #7 😬 |
I've been fighting with getting this to work properly in GitLab CI with projects where we're just starting to adopt
The first issue I had was with the The 2nd issue I'm currently wrestling with is although this now gives the correct starting from commit hash as I would expect from looking at The CI job definition is:
Cheers |
I tested
with success so far. |
<a name="2.1.0"></a> # [2.1.0](v1.1.9...v2.1.0) (2017-07-07) ### Bug Fixes * prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427)) * rebuff rules ([#34](#34)) ([702a2f7](702a2f7)) * throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12) * update to latest angular config ([b1f3606](b1f3606)) ### Features * ignore fixup and squash commit ([#17](#17)) ([f0b83d8](f0b83d8))
… (2017-07-07) ### Bug Fixes * prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427)) * rebuff rules ([#34](#34)) ([702a2f7](702a2f7)) * throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12) * update to latest angular config ([b1f3606](b1f3606)) ### Features * ignore fixup and squash commit ([#17](#17)) ([f0b83d8](f0b83d8))
… (2017-07-07) ### Bug Fixes * prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427)) * rebuff rules ([#34](#34)) ([702a2f7](702a2f7)) * throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12) * update to latest angular config ([b1f3606](b1f3606)) ### Features * ignore fixup and squash commit ([#17](#17)) ([f0b83d8](f0b83d8))
… (2017-07-07) ### Bug Fixes * prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427)) * rebuff rules ([#34](#34)) ([702a2f7](702a2f7)) * throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12) * update to latest angular config ([b1f3606](b1f3606)) ### Features * ignore fixup and squash commit ([#17](#17)) ([f0b83d8](f0b83d8))
… (2017-07-07) ### Bug Fixes * prevent false positives for footer-leading-blank ([#33](#33)) ([05b4427](05b4427)) * rebuff rules ([#34](#34)) ([702a2f7](702a2f7)) * throw when detecting a shallow clone ([8c354c5](8c354c5)), closes [#7](#7) [#12](#12) * update to latest angular config ([b1f3606](b1f3606)) ### Features * ignore fixup and squash commit ([#17](#17)) ([f0b83d8](f0b83d8))
I'd like to integrate
conventional-changelog-lint
into my CI process. I can enforce a commit convention on "client side" using Husky as per docs, but how would I enforce the convention on CI?Assuming that a PR is a list of commits that do not exist on master, then getting those commits is simple:
git log master..$(git symbolic-ref --short HEAD)
I am not sure though whats the best way to feed them to conventional-changelog-lint. Here is what I have ended up with for now:
The problem with the latter is that it doesn't exit if either of the validation fails.
The text was updated successfully, but these errors were encountered: