Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config-workspace-scopes): add config preset for npm and yarn workspaces #4269

Merged

Conversation

janbiasi
Copy link
Contributor

@janbiasi janbiasi commented Feb 3, 2025

Description

Extract workspaces config into its own package.
Set the NPM constraint to 7+ as v7 introduced workspaces.

Motivation and Context

Please see the long explanation in #4262

Usage examples

// commitlint.config.js
module.exports = {
  extends: ['@commitlint/config-workspace-scopes']
};
echo "feat(nonexisting-pkg): your commit message here" | commitlint # fails
echo "feat(existing-pkg): your commit message here" | commitlint # passes

How Has This Been Tested?

Local test suite in the project based on the current lerna implementation

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codesandbox-ci bot commented Feb 3, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@janbiasi janbiasi marked this pull request as ready for review February 15, 2025 13:45
@escapedcat
Copy link
Member

Thanks @janbiasi !

@escapedcat escapedcat merged commit 67ff9e8 into conventional-changelog:master Feb 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants