Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the list of possible values for ocaml_version in the README #42

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

erikmd
Copy link
Member

@erikmd erikmd commented Dec 15, 2020

Kind: this is a documentation-only PR.

@Zimmi48 could you have a look at this PR and merge it if you approve it? (or directly modify the branch if need be!)

indeed given coq-community/docker-coq#23, it appears it'd be good to document the current state of supported ocaml_versions from Docker-Coq in the master README (in the same way as I had documented the on-going change in the docker-coq wiki) and this, even if #39 which will bring yet more documentation, is not yet ready.

+ a link to the wiki documenting the correspondence with coq_version.
@erikmd erikmd added the documentation Improvements or additions to documentation label Dec 15, 2020
@erikmd erikmd requested a review from Zimmi48 December 15, 2020 00:38
@erikmd
Copy link
Member Author

erikmd commented Dec 15, 2020

Merging now as a follow-up of #43

@erikmd erikmd merged commit 5ce41b8 into master Dec 15, 2020
@erikmd erikmd deleted the document-ocaml branch December 15, 2020 12:19
@Zimmi48
Copy link
Member

Zimmi48 commented Dec 15, 2020

LGTM but shouldn't there be some warning that not all OCaml versions are available with all Coq versions?

@erikmd
Copy link
Member Author

erikmd commented Dec 15, 2020

LGTM but shouldn't there be some warning that not all OCaml versions are available with all Coq versions?

Indeed, I will push a small remark in master about this. Thanks!

erikmd added a commit that referenced this pull request Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants