generated from actions/container-action
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta-ci: Add an automated test-suite for docker-coq-action@$GITHUB_SHA
#60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 6 jobs that illustrate, and test, typical combinations of docker-coq-action's customizable fields: - coq_version, ocaml_version & opam_file - custom_image & opam_file - custom_image & install, script, uninstall (may need perms' workaround) - custom_image & custom_script (may need perms' workaround) - custom_image & opam_file & script or so & export - custom_image & opam_file & before_script, after_script (using apt-get)
* a GHA job that illustrates, and tests, the availability of docker-coq-action as a general-purpose wrapper for Docker-based tests. * See also: href: https://github.com/erikmd/poc-github-ci href: https://hub.docker.com/_/python (python:3)
c1050e9
to
ecb3fca
Compare
(as "uses: coq-community/docker-coq-action@${{ github.sha }}" isn't supported) & Avoid the use of "needs:" jobs (as the workspace is not shared among jobs) & Fix URL of repo (erikmd/docker-coq-github-action-demo)
* href: https://github.com/coq-community/docker-coq-action/actions/runs/1114221825 The workflow is not valid. .github/workflows/coq-demo.yml: Anchors are not currently supported. Remove the anchor 'setup-coq-demo' * Hence this not-DRY-compliant commit.
(as https://github.com/erikmd/docker-coq-github-action-demo does not contain any Makefile currently) Obviously, the scripts are project-specific… hence the interest to use docker-coq-action's opam_file variant to be more generic/user-friendly
erikmd
added a commit
that referenced
this pull request
Aug 9, 2021
(§) notably, hyperlinks to the workflows added in PR #60
erikmd
added a commit
that referenced
this pull request
Aug 9, 2021
(§) notably, hyperlinks to the workflows added in PR #60
If you intended to automatically close #46, somehow it didn't happen. |
@Zimmi48, indeed, thanks for the heads-up! |
erikmd
added a commit
that referenced
this pull request
Aug 11, 2021
Improving the README.md after merging PR #60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new feature adds 7 more GHA jobs, which are intended to both:
coq-community/docker-coq-action
without needing to open another accompanying PR in https://github.com/erikmd/docker-coq-github-action-demo;
also note that no Coq code is committed along with this PR, thanks to the
repository:
field ofactions/checkout
.