Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta-ci: Add an automated test-suite for docker-coq-action@$GITHUB_SHA #60

Merged
merged 5 commits into from
Aug 9, 2021

Conversation

erikmd
Copy link
Member

@erikmd erikmd commented Aug 9, 2021

This new feature adds 7 more GHA jobs, which are intended to both:

  • illustrate some typical use cases / "workflows" of coq-community/docker-coq-action
  • and ease the test/review of new features,

without needing to open another accompanying PR in https://github.com/erikmd/docker-coq-github-action-demo;

also note that no Coq code is committed along with this PR, thanks to the repository: field of actions/checkout.

erikmd added 2 commits August 9, 2021 20:06
* 6 jobs that illustrate, and test, typical combinations of docker-coq-action's
  customizable fields:

  - coq_version, ocaml_version & opam_file
  - custom_image & opam_file

  - custom_image & install, script, uninstall (may need perms' workaround)
  - custom_image & custom_script (may need perms' workaround)

  - custom_image & opam_file & script or so & export
  - custom_image & opam_file & before_script, after_script (using apt-get)
* a GHA job that illustrates, and tests, the availability of docker-coq-action
  as a general-purpose wrapper for Docker-based tests.

* See also:
  href: https://github.com/erikmd/poc-github-ci
  href: https://hub.docker.com/_/python (python:3)
@erikmd erikmd added the feature label Aug 9, 2021
@erikmd erikmd self-assigned this Aug 9, 2021
@erikmd erikmd force-pushed the meta-ci branch 2 times, most recently from c1050e9 to ecb3fca Compare August 9, 2021 20:03
(as "uses: coq-community/docker-coq-action@${{ github.sha }}" isn't supported)

& Avoid the use of "needs:" jobs (as the workspace is not shared among jobs)

& Fix URL of repo (erikmd/docker-coq-github-action-demo)
erikmd added 2 commits August 9, 2021 22:26
* href: https://github.com/coq-community/docker-coq-action/actions/runs/1114221825

  The workflow is not valid. .github/workflows/coq-demo.yml: Anchors are not currently supported. Remove the anchor 'setup-coq-demo'

* Hence this not-DRY-compliant commit.
(as https://github.com/erikmd/docker-coq-github-action-demo
does not contain any Makefile currently)

Obviously, the scripts are project-specific… hence the interest to use
docker-coq-action's opam_file variant to be more generic/user-friendly
@erikmd erikmd merged commit eb3ce2c into master Aug 9, 2021
@erikmd erikmd deleted the meta-ci branch August 9, 2021 21:29
erikmd added a commit that referenced this pull request Aug 9, 2021
(§) notably, hyperlinks to the workflows added in PR #60
erikmd added a commit that referenced this pull request Aug 9, 2021
(§) notably, hyperlinks to the workflows added in PR #60
@Zimmi48
Copy link
Member

Zimmi48 commented Aug 11, 2021

If you intended to automatically close #46, somehow it didn't happen.

@erikmd
Copy link
Member Author

erikmd commented Aug 11, 2021

@Zimmi48, indeed, thanks for the heads-up!
Maybe Closing https://… was not a supported syntax, unlike Close #…

erikmd added a commit that referenced this pull request Aug 11, 2021
Improving the README.md after merging PR #60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants