[CORL-3224]: ensure replies to rejected parent comments are not included in comment count #4757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g a rejected parent
✅ Deploy Preview for gallant-galileo-14878c canceled.
|
kabeaty
commented
Feb 28, 2025
| @@ -645,13 +645,6 @@ const enhanced = withPaginationContainer< | |||
| } | |||
| mode | |||
| } | |||
| commentCounts { | |||
There was a problem hiding this comment.
Removed this since it doesn't seem to be used...
…ithub.com:coralproject/talk into fix/CORL-3224-replies-hidden-parent-comment-count
nick-funk
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These changes ensure that when replies in the stream have rejected ancestor comments, they are not included in the comment count shown since they are not visible. The changes use
totalPublishedAndVisiblefor the stream now. A newrejectedAncestorIDson comments is used to keep track of whether a comment has any rejected ancestors and is therefore hidden. A newPUBLISHED_COMMENTS_WITH_REJECTED_ANCESTORShas been added to counts to keep track of these in a count that can then be used to determine the newtotalPublishedAndVisible.Having
rejectedAncestorIDson comments may be useful to us in other places too. For example, currently, we have ahasRejectedAncestorsfunction inserver/src/core/server/services/comments/comments.ts. We could refactor this to utilize the newrejectedAncestorIDs.These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
To GraphQL, these changes add
rejectedAncestorIDs. Also, to comment counts,totalPublishedAndVisibleandrelationships: {PUBLISHED_COMMENTS_WITH_REJECTED_ANCESTORS: number}.To database schema,
rejectedAncestorIDshas been added to comments. Also, to comment counts,relationships: {PUBLISHED_COMMENTS_WITH_REJECTED_ANCESTORS: number}has been added.Does this PR introduce any new environment variables or feature flags?
no
If any indexes were added, were they added to
INDEXES.md?TODO: Confirm if any new indexes are needed
How do I test this PR?
You can test these changes by testing that comment counts are still working as expected.
Also, create a bunch of comments in the stream. Include levels of replies. Reject and approve comments and replies at all different levels. Reject and approve replies to already rejected ancestors. See that the stream's comment count updates according to how many comments are actually visible in the stream.
Were any tests migrated to React Testing Library?
no
How do we deploy this PR?