Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: buildprep from latest testing-devel #176

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Sep 20, 2019

That way if a PR adds a package, we'll print the pkg diff.

@jlebon
Copy link
Member Author

jlebon commented Sep 20, 2019

ostree diff commit from: eb9c3da15432707382294fca7e1a2c80aa81768ec5ce14aedcc181491a00b897
ostree diff commit to: c12b04a3eff9495d52f65a40cdc8581028988e1170fce08160f41080061fb3fc

Understandably, there's no diff in this PR, but it's comparing to the previous commit, which is the important part.

@ajeddeloh
Copy link
Contributor

This LGTM but are there plans to make this more visible from GH? It's somewhat buried atm, which I suppose is fine since it only applies to a certain set of PRs. OTOH more visibility is better.

@jlebon
Copy link
Member Author

jlebon commented Sep 20, 2019

This LGTM but are there plans to make this more visible from GH?

There aren't plans not to ;)

@jlebon jlebon force-pushed the pr/db-diff branch 2 times, most recently from d22b91b to b726a5f Compare September 20, 2019 19:50
@jlebon
Copy link
Member Author

jlebon commented Sep 20, 2019

I made it print the pkgdiff as a separate stage at least so it's easier to access. ⬆️

Copy link
Contributor

@ajeddeloh ajeddeloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to separate stage for visibility.

@ajeddeloh
Copy link
Contributor

CI is failing for unrelated reasons. Is there anything blocking this?

@jlebon
Copy link
Member Author

jlebon commented Sep 26, 2019

No I think the CI failure is related, I'm just not sure how yet.

Verified

This commit was signed with the committer’s verified signature.
lowr LowR
That way if a PR adds a package, we'll print the pkg diff.
@jlebon
Copy link
Member Author

jlebon commented Feb 28, 2020

OK, let's try this again on top of the new CI!

@cgwalters cgwalters merged commit 341fb56 into coreos:testing-devel Feb 28, 2020
@jlebon jlebon deleted the pr/db-diff branch April 23, 2023 23:28
dustymabe pushed a commit to jbtrystram/fedora-coreos-config that referenced this pull request Apr 19, 2024

Verified

This commit was signed with the committer’s verified signature.
lowr LowR
The Fedora docs template footer specifies CC-BY-SA 3.0.  Add a copy
of the license to the repository for clarity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants