treefile: Add container-cmd
#3402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds on ostreedev/ostree-rs-ext#235 Part of coreos/coreos-assembler#2685 Note making use of this will require bumping ostree-ext here.
cgwalters
commented
Feb 4, 2022
| @@ -761,6 +761,18 @@ rpm_ostree_compose_context_new (const char *treefile_pathstr, | |||
| return FALSE; | |||
| } | |||
|
|
|||
| auto cmd = (*self->treefile_rs)->get_container_cmd(); | |||
There was a problem hiding this comment.
Man, passing data between Rust to C++ then to C sucks 😢
cgwalters
added a commit
to cgwalters/fedora-coreos-config
that referenced
this pull request
Feb 4, 2022
Builds on coreos/rpm-ostree#3402 Relates to coreos/coreos-assembler#2685 Basically, source of truth for the CMD moves from being hardcoded in cosa hackiliy to being part of the ostree commit, which means it survives a full round trip of ostree → container → ostree → container
|
Tested with coreos/fedora-coreos-config#1484 and coreos/coreos-assembler#2687 |
cgwalters
added a commit
to cgwalters/fedora-coreos-config
that referenced
this pull request
Mar 7, 2022
Builds on coreos/rpm-ostree#3402 Relates to coreos/coreos-assembler#2685 Basically, source of truth for the CMD moves from being hardcoded in cosa hackiliy to being part of the ostree commit, which means it survives a full round trip of ostree → container → ostree → container
cgwalters
added a commit
to cgwalters/fedora-coreos-config
that referenced
this pull request
Mar 8, 2022
Builds on coreos/rpm-ostree#3402 Relates to coreos/coreos-assembler#2685 Basically, source of truth for the CMD moves from being hardcoded in cosa hackiliy to being part of the ostree commit, which means it survives a full round trip of ostree → container → ostree → container
jlebon
pushed a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Mar 8, 2022
Builds on coreos/rpm-ostree#3402 Relates to coreos/coreos-assembler#2685 Basically, source of truth for the CMD moves from being hardcoded in cosa hackiliy to being part of the ostree commit, which means it survives a full round trip of ostree → container → ostree → container
HuijingHei
pushed a commit
to HuijingHei/fedora-coreos-config
that referenced
this pull request
Oct 10, 2023
Builds on coreos/rpm-ostree#3402 Relates to coreos/coreos-assembler#2685 Basically, source of truth for the CMD moves from being hardcoded in cosa hackiliy to being part of the ostree commit, which means it survives a full round trip of ostree → container → ostree → container
HuijingHei
pushed a commit
to HuijingHei/fedora-coreos-config
that referenced
this pull request
Oct 10, 2023
Builds on coreos/rpm-ostree#3402 Relates to coreos/coreos-assembler#2685 Basically, source of truth for the CMD moves from being hardcoded in cosa hackiliy to being part of the ostree commit, which means it survives a full round trip of ostree → container → ostree → container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on ostreedev/ostree-rs-ext#235
Part of coreos/coreos-assembler#2685
Note making use of this will require bumping ostree-ext here.