compose-image: Add --layer-repo option
#4005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new `compose image` container-native flow has a gap: we need to be able to specify an input ostree repository for the `ostree-layers` and `ostree-override-layers` bits. I'm experimenting with rebasing the guts of `cosa build` for FCOS on top of `compose image`, and this is the main gap.
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Sep 12, 2022
Part of coreos#2685 I'm looking at replacing the guts of `cosa build ostree` with the new container-native `rpm-ostree compose image`. In order for that to work, we need two things: - The committed overlays from `overlays/` - xref coreos/rpm-ostree#4005 - The rendered `image.json` which is also an overlay now Basically in combination with the above PR, this works now when invoked manually: ``` $ cosa build --prepare-only $ sudo rpm-ostree compose image --cachedir=cache/buildimage --layer-repo tmp/repo src/config/manifest.yaml oci:tmp/fcos.oci ```
|
@cgwalters: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Sep 12, 2022
Part of coreos#2685 I'm looking at replacing the guts of `cosa build ostree` with the new container-native `rpm-ostree compose image`. In order for that to work, we need two things: - The committed overlays from `overlays/` - xref coreos/rpm-ostree#4005 - The rendered `image.json` which is also an overlay now Basically in combination with the above PR, this works now when invoked manually: ``` $ cosa build --prepare-only $ sudo rpm-ostree compose image --cachedir=cache/buildimage --layer-repo tmp/repo src/config/manifest.yaml oci:tmp/fcos.oci ```
cgwalters
added a commit
to coreos/coreos-assembler
that referenced
this pull request
Sep 13, 2022
Part of #2685 I'm looking at replacing the guts of `cosa build ostree` with the new container-native `rpm-ostree compose image`. In order for that to work, we need two things: - The committed overlays from `overlays/` - xref coreos/rpm-ostree#4005 - The rendered `image.json` which is also an overlay now Basically in combination with the above PR, this works now when invoked manually: ``` $ cosa build --prepare-only $ sudo rpm-ostree compose image --cachedir=cache/buildimage --layer-repo tmp/repo src/config/manifest.yaml oci:tmp/fcos.oci ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
compose imagecontainer-native flow has a gap: we need to be able to specify an input ostree repository for theostree-layersandostree-override-layersbits.I'm experimenting with rebasing the guts of
cosa buildfor FCOS on top ofcompose image, and this is the main gap.