Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter linter and more godoc #24

Merged
merged 2 commits into from
Apr 24, 2019
Merged

Stricter linter and more godoc #24

merged 2 commits into from
Apr 24, 2019

Conversation

corneliusweig
Copy link
Owner

No description provided.

Cornelius Weig added 2 commits April 24, 2019 01:39
Some issues are still only found by golint
@codecov-io
Copy link

codecov-io commented Apr 24, 2019

Codecov Report

Merging #24 into master will increase coverage by 0.23%.
The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   73.33%   73.56%   +0.23%     
==========================================
  Files          15       15              
  Lines         630      628       -2     
==========================================
  Hits          462      462              
+ Misses        145      143       -2     
  Partials       23       23
Impacted Files Coverage Δ
pkg/rakkess/client/result/resource.go 100% <ø> (ø) ⬆️
pkg/rakkess/version/version.go 27.27% <ø> (ø) ⬆️
pkg/rakkess/client/fetch_resources.go 6.06% <ø> (ø) ⬆️
pkg/rakkess/validation/validation.go 75% <0%> (+8.33%) ⬆️
cmd/root.go 26.92% <0%> (+1.92%) ⬆️
pkg/rakkess/client/result/subject.go 91.42% <0%> (-2.69%) ⬇️
pkg/rakkess/client/resource_access.go 63.51% <0%> (ø) ⬆️
pkg/rakkess/client/user_access.go 83.33% <100%> (ø) ⬆️
pkg/rakkess/printer/printer.go 89.36% <100%> (ø) ⬆️
pkg/rakkess/printer/terminal_notwindows.go 60% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dda8c0...11b0cb2. Read the comment docs.

@corneliusweig corneliusweig merged commit a08ad64 into master Apr 24, 2019
@corneliusweig corneliusweig deleted the linter-warnings branch April 24, 2019 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants