Use native cobra zsh completion script generator instead of wrapper script #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 27, 2019 20:28
So far, there was a wrapper script to translate bash completion into zsh code. This now uses the native zsh completion which was introduced in v0.0.5
The vanilla version assumes that the completion script is generated once and then put in the zsh completion script folder. This has advantages, such as better caching, but it breaks the most common use-case `source <(rakkess completion zsh)` This commit adds a compdef call which re-enables this usage. Also see spf13/cobra#887
corneliusweig
force-pushed
the
w/zsh-completion
branch
from
f29faa0 to
b485582
Compare
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
==========================================
+ Coverage 73.3% 74.22% +0.91%
==========================================
Files 15 15
Lines 487 481 -6
==========================================
Hits 357 357
+ Misses 103 100 -3
+ Partials 27 24 -3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.