Explicitly enable color escape sequences on windows #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually, logrus does this when printing the first log message. Since we usually don't log anything before printing, this setup work needs to be done manually. The implementation is very much based on that from logrus. Fixes #6
corneliusweig
force-pushed
the
powershell-colors
branch
from
085403d to
20a7f2c
Compare
|
Works beautifully for me! Nice find - I might try to port this back to Draft if you have no objections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem of colored output in PowerShell has been tackled by logrus and konsorten. However, due to the lack of logging, the color codes are not enabled on PowerShell for
rakkess. Therefore, this PR explicitly enables ANSI color codes in PowerShell.Fixes #6
@itowlson Could you kindly check if this works for you?