Fix implib name for *-pc-windows-gnullvm targets.
#546
Conversation
|
Is there a corresponding clang target? I'm assuming that means gnu and gnullvm are not abi compatible, is that correct? |
|
Probably not ABI compatible, afaik one links against the GCC runtime and the other links against the LLVM runtime/Microsoft's Univerisal C Runtime. As for Clang targets - I'm not sure, my usecase was linking a cdynlib against a C++ project compiled with llvm-mingw . |
| if(is_windows_gnullvm) | ||
| _corrosion_set_imported_location("${target_name}-shared" "IMPORTED_IMPLIB" | ||
| "ARCHIVE_OUTPUT_DIRECTORY" | ||
| "${dynamic_lib_name}" |
There was a problem hiding this comment.
Why not just skip adding the IMPLIB artifact altogether? What does Cmake do for C++ sharedlibraries compiling with the corresponding C/C++ toolchain?
There was a problem hiding this comment.
I would need to look into what CMake does, the reason I set the artifact was to get it to pass the .dll path to the linker, might well be the wrong way to do it.
|
#553 added a workaround to correctly copy the implib on gnullvm targets. |
|
thank you! |
*-pc-windows-gnullvmtargets only output a.dllfile without the.libfile. Not all linkers for windows support linking directly against .dll's, configuring the linker correctly is left up to the user.