Update unit tests for distributor push native histograms #6020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedrichg
approved these changes
Jun 18, 2024
CharlieTLe
reviewed
Jun 21, 2024
CharlieTLe
reviewed
Jun 21, 2024
pkg/distributor/distributor_test.go
Outdated
| @@ -3481,7 +3658,7 @@ func TestDistributor_Push_Relabel(t *testing.T) { | |||
| }) | |||
|
|
|||
| // Push the series to the distributor | |||
| req := mockWriteRequest(tc.inputSeries, 1, 1) | |||
| req := mockWriteRequest(tc.inputSeries, 1, 1, false) | |||
There was a problem hiding this comment.
Should we test for the histogram=true case as well?
There was a problem hiding this comment.
I didn't change it because relabel logic ideally has nothing to do with whether native histogram data or not.
But yeah I can cover histogram test case too
There was a problem hiding this comment.
Updated: fixed in latest commit
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
yeya24
force-pushed
the
update-distributor-test-native-histograms
branch
from
5646767 to
dd9b196
Compare
yeya24
changed the title
CharlieTLe
reviewed
Jun 23, 2024
pkg/distributor/distributor_test.go
Outdated
| @@ -620,7 +706,7 @@ func TestPush_QuorumError(t *testing.T) { | |||
| ingesters[2].failResp.Store(httpgrpc.Errorf(429, "Throttling")) | |||
|
|
|||
| for i := 0; i < numberOfWrites; i++ { | |||
| request := makeWriteRequest(0, 30, 20) | |||
| request := makeWriteRequest(0, 30, 20, 0) | |||
There was a problem hiding this comment.
Should we test for the native histogram case here as well?
There was a problem hiding this comment.
I don't know if it is nencessary since histogram doesn't change anything related to quorum. And we mock response here anyway.
There was a problem hiding this comment.
Updated the test to include histogram writes.
Signed-off-by: Ben Ye <[email protected]>
CharlieTLe
approved these changes
Jun 24, 2024
|
Thanks, merging now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Follow up of #5986.
Update unit tests for distributor push and query native histograms.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]