Create a goroutine worker pool to send data from distributors to ingesters. #6406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanprot
commented
Dec 7, 2024
Comment on lines
126
to
+131
| for _, i := range instances { | ||
| go func(i instance) { | ||
| e.Submit(func() { | ||
| err := callback(i.desc, i.indexes) | ||
| tracker.record(i, err) | ||
| wg.Done() | ||
| }(i) | ||
| }) |
There was a problem hiding this comment.
The closure var should be fine now:
https://tip.golang.org/doc/go1.22
Previously, the variables declared by a “for” loop were created once and updated by each iteration. In Go 1.22, each iteration of the loop creates new variables, to avoid accidental sharing bugs. The transition support tooling described in the proposal continues to work in the same way it did in Go 1.21.
alanprot
force-pushed
the
distributor-worker-pool
branch
from
bb63874 to
2a0e956
Compare
alanprot
force-pushed
the
distributor-worker-pool
branch
2 times, most recently
from
ea066bd to
3c5ff63
Compare
yeya24
approved these changes
Dec 9, 2024
Signed-off-by: alanprot <[email protected]>
Signed-off-by: alanprot <[email protected]>
alanprot
force-pushed
the
distributor-worker-pool
branch
from
3c5ff63 to
4bbfa0c
Compare
I forgot about changelog. :P Yeah.. lemme mark as experimental. |
Signed-off-by: alanprot <[email protected]>
CharlieTLe
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Implement an option to use a goroutine worker pool to handle requests from the distributor to ingesters, rather than spawning a new goroutine for each request.
This PR was inspired on: grpc/grpc-go#3204
Looking at the distributor flame graph, we could see that lots of cpu was being used on the
runtime.newstackcall:This problem increases with the RemoteWrite TPS and the number of ingesters in the cluster (as, for request and ingesters, we create a new go routine).
With this PR enabled, we could see a reduction on 20% of CPU on some cortex cluster with hundreds of ingesters.
We could not see any
runtime.newstackon the cpu flamegraph after the option was enabled.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]