Add cleaner logic to clean partition compaction blocks and related files #6507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Le <[email protected]>
Signed-off-by: Alex Le <[email protected]>
Signed-off-by: Alex Le <[email protected]>
yeya24
reviewed
Jan 15, 2025
| }) | ||
|
|
||
| if err != nil { | ||
| level.Warn(userLogger).Log("msg", "error return when going through partitioned group directory", "err", err) |
There was a problem hiding this comment.
I don't see we return any error in the iter function above. Is this error mainly failure of listing files in the bucket?
There was a problem hiding this comment.
Right. In this code, we try to get as many as partition group info files. If there is any issue inside iter function, we just stop and processing what we got. Any retriable error would be covered by next cleaner cycle.
Signed-off-by: Alex Le <[email protected]>
yeya24
approved these changes
Jan 15, 2025
alexqyle
added a commit
to alexqyle/cortex
that referenced
this pull request
Jan 31, 2025
…les (cortexproject#6507) * Add cleaner logic to clean partition compaction blocks and related files Signed-off-by: Alex Le <[email protected]> * refactored metrics Signed-off-by: Alex Le <[email protected]> * refactor Signed-off-by: Alex Le <[email protected]> * update logs Signed-off-by: Alex Le <[email protected]> --------- Signed-off-by: Alex Le <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Added extra logic in block cleaner to handle partitioning compaction related logic. Cleaner would delete compacted blocks from partitioning compaction because partitioning compaction will not delete any parent blocks on compaction complete since those parent blocks would be used to compact other partition from the same time range. Cleaner would use partition group info file along with partition visit marker to determine if parent blocks can be deleted or not. Cleaner also would delete partition group info file and partition visit marker accordingly.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]