Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky cosmovisor test #18073

Closed
Tracked by #20067
julienrbrt opened this issue Oct 11, 2023 · 1 comment · Fixed by #18262
Closed
Tracked by #20067

Flaky cosmovisor test #18073

julienrbrt opened this issue Oct 11, 2023 · 1 comment · Fixed by #18262
Labels
C:Cosmovisor Issues and PR related to Cosmovisor T: Tests

Comments

@julienrbrt
Copy link
Member

This test has been flaky lately: https://github.com/cosmos/cosmos-sdk/actions/runs/6481714995/job/17607755004?pr=18052
@julienrbrt julienrbrt added T: Tests C:Cosmovisor Issues and PR related to Cosmovisor labels Oct 11, 2023
@julienrbrt julienrbrt self-assigned this Oct 12, 2023
@odeke-em odeke-em mentioned this issue Oct 26, 2023
Merged
@julienrbrt julienrbrt removed their assignment Oct 26, 2023
odeke-em added a commit that referenced this issue Oct 26, 2023
@odeke-em
test(cosmovisor): improve TestParseUpgradeInfoFile with substring ass…
8537b5a 
…ertions

In trying to investigate the flake reported in #18073, this change
adds the context of the failing test's filepath. This change allows
us to tighten the tests by using assertions on the error instead of
just checking that it is non-nil.
Also one of the tests that claimed it was empty actually had a
space/newline which meant that it wasn't testing the right expectations.

Updates #18073
@julienrbrt julienrbrt linked a pull request Oct 26, 2023 that will close this issue
test(cosmovisor): improve TestParseUpgradeInfoFile with substring assertions #18262
Merged
odeke-em added a commit that referenced this issue Oct 27, 2023
@odeke-em
test(cosmovisor): improve TestParseUpgradeInfoFile with substring ass…
42c90bf 
…ertions

In trying to investigate the flake reported in #18073, this change
adds the context of the failing test's filepath. This change allows
us to tighten the tests by using assertions on the error instead of
just checking that it is non-nil.
Also one of the tests that claimed it was empty actually had a
space/newline which meant that it wasn't testing the right expectations.

Updates #18073
@julienrbrt julienrbrt reopened this Oct 30, 2023
@julienrbrt julienrbrt mentioned this issue Apr 17, 2024
Closed
7 tasks
@julienrbrt julienrbrt mentioned this issue Aug 9, 2024
Merged
12 tasks
@julienrbrt
Copy link
Member Author

julienrbrt commented Aug 12, 2024 •
edited
Loading

Supersede by #21086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:Cosmovisor Issues and PR related to Cosmovisor T: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(cosmovisor): improve TestParseUpgradeInfoFile with substring assertions cosmos/cosmos-sdk
1 participant
@julienrbrt