-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix the note box syntax error #20499
Conversation
WalkthroughWalkthroughThe changes primarily involve updates to the documentation formatting in two README.md files. Specifically, the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (3)
x/protocolpool/README.md (3)
Line range hint
152-155
: Standardize the list item markers to use asterisks instead of dashes for consistency.- - The msg will fail if the amount cannot be transferred from the sender to the protocolpool module account. + * The msg will fail if the amount cannot be transferred from the sender to the protocolpool module account.Also applies to: 171-173, 193-194
Line range hint
61-61
: Remove the trailing space to adhere to Markdown best practices.- It's the responsibility of users to actively claim their allocated funds based on the terms of the approved budget proposals. + It's the responsibility of users to actively claim their allocated funds based on the terms of the approved budget proposals.
Line range hint
95-95
: Replace hard tabs with spaces to maintain consistency in indentation.- // CreateContinuousFund defines a method to add funds continuously. + // CreateContinuousFund defines a method to add funds continuously. - // CancelContinuousFund defines a method for cancelling continuous fund. + // CancelContinuousFund defines a method for cancelling continuous fund.Also applies to: 114-114
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (2)
- docs/README.md (1 hunks)
- x/protocolpool/README.md (1 hunks)
Files skipped from review due to trivial changes (1)
- docs/README.md
Additional context used
Path-based instructions (1)
x/protocolpool/README.md (1)
Pattern
**/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
Markdownlint
x/protocolpool/README.md
152-152: Expected: asterisk; Actual: dash
Unordered list style
153-153: Expected: asterisk; Actual: dash
Unordered list style
154-154: Expected: asterisk; Actual: dash
Unordered list style
155-155: Expected: asterisk; Actual: dash
Unordered list style
171-171: Expected: asterisk; Actual: dash
Unordered list style
172-172: Expected: asterisk; Actual: dash
Unordered list style
173-173: Expected: asterisk; Actual: dash
Unordered list style
193-193: Expected: asterisk; Actual: dash
Unordered list style
194-194: Expected: asterisk; Actual: dash
Unordered list style
61-61: Expected: 0 or 2; Actual: 1
Trailing spaces
95-95: Column: 1
Hard tabs
114-114: Column: 1
Hard tabs
Additional comments not posted (1)
x/protocolpool/README.md (1)
85-85
: Fix the closing tag for the tip block to ensure it displays correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* main: (120 commits) chore: update protoc-gen-swagger to protoc-gen-openapiv2 (#20448) ci: Add GitHub Action for go mod tidy and mocks (#20501) chore: Address linter issues (#20486) fix: wrap errors in auto CLI service registration (#20493) chore: fix comment (#20498) chore: fix the note box syntax error (#20499) feat(server/v2): introduce cometbft v2 (#20483) refactor(x/upgrade): migrate to appmodule.VersionMap (#20485) docs: code guidelines changes (#20482) feat(cosmovisor): load cosmovisor configuration from toml file (#19995) perf(math): Significantly speedup Dec quo truncate and quo Roundup (#20034) fix: Bump CometBFT versions (#20481) refactor(core): remove redundant ExecMode (#20322) feat(store/v2): pruning manager (#20430) chore: force reload sonar cloud (#20480) refactor(x/accounts): reuse calculated sum in `func safeAdd` (#20458) refactor: remove `defer` in loop (#20223) ci: remove livness test (#20474) build(deps): Bump bufbuild/buf-setup-action from 1.32.1 to 1.32.2 (#20477) chore: migrate a few diagrams to mermaid (#20473) ...
Description
fixed two syntaxes to make the blocks show as expected.
Summary by CodeRabbit
docs/README.md
for improved readability.protocolpool
module documentation.