Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add x/protocolpool #23933

Draft
wants to merge 19 commits into
base: release/v0.53.x
Choose a base branch
from
Draft

chore: add x/protocolpool #23933

wants to merge 19 commits into from

Conversation

aljo242
Copy link
Collaborator

@aljo242 aljo242 commented Mar 7, 2025

keeping as a draft

  • add module
  • add proto
  • add to legacy and di applications
  • update readme
  • add legacy amino
  • make compatible with v53

TODO:

  • reintegrate sims
  • get all fixes into x/distr
  • add switchover logic to x/distr

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gosec found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

func (am AppModule) BeginBlock(ctx context.Context) error {
sdkCtx := sdk.UnwrapSDKContext(ctx)

return am.keeper.BeginBlocker(sdkCtx)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant