Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add InitOptions to x/distribution keeper for protocol pool enabling #23936

Draft
wants to merge 6 commits into
base: chore/pp
Choose a base branch
from

Conversation

aljo242
Copy link
Collaborator

@aljo242 aljo242 commented Mar 7, 2025

This PR just adds and wires the options. We have 2 ways to configure

  1. if using the declarative app.go system, just provide the WithProtocolPoolEnabled() option
  2. if using depinject, set the ProtocolPoolEnabled flag in your module config

@github-actions github-actions bot added the C:x/distribution distribution module related label Mar 7, 2025
app.StakingKeeper,
authtypes.FeeCollectorName,
authtypes.NewModuleAddress(govtypes.ModuleName).String(),
distrkeeper.WithProtocolPoolEnabled(),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding this option

Config: appconfig.WrapAny(&distrmodulev1.Module{}),
Name: distrtypes.ModuleName,
Config: appconfig.WrapAny(&distrmodulev1.Module{
ProtocolPoolEnabled: true,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

di option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/distribution distribution module related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant