Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CacheMultiStoreWithVersion (inter-block cache) #4997

Merged
merged 3 commits into from
Sep 5, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Sep 4, 2019

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez requested review from AdityaSripal, colin-axner and tnachen and removed request for alessio September 4, 2019 19:57
@codecov
Copy link

codecov bot commented Sep 4, 2019

Codecov Report

Merging #4997 into master will increase coverage by <.01%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master    #4997      +/-   ##
==========================================
+ Coverage   55.56%   55.56%   +<.01%     
==========================================
  Files         287      287              
  Lines       17514    17521       +7     
==========================================
+ Hits         9731     9735       +4     
- Misses       7083     7085       +2     
- Partials      700      701       +1

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alexanderbez alexanderbez merged commit 2d18f1e into master Sep 5, 2019
@alexanderbez alexanderbez deleted the bez/fix-CacheMultiStoreWithVersion branch September 5, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants