Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing unit tests #2

Closed
anxolin opened this issue Apr 3, 2022 · 0 comments · Fixed by #9
Closed

Add missing unit tests #2

anxolin opened this issue Apr 3, 2022 · 0 comments · Fixed by #9
Assignees
@matextrem
Labels
Protofire

Comments

@anxolin
Copy link
Contributor

anxolin commented Apr 3, 2022

Description

Add unit tests for the public methods:

  • signOrder
  • signOrderCancellation
  • cowApi.getProfileData
  • cowApi.getTrades
  • cowApi.getOrders
  • cowApi.getOrder
  • cowApi.getPriceQuoteLegacy
  • cowApi.sendSignedOrderCancellation
  • cowApi.sendOrder

Original issue gnosis/cow-sdk#11 by @ramirotw
@matextrem matextrem mentioned this issue Apr 8, 2022
Merged
shoom3301 added a commit that referenced this issue Feb 28, 2023
@shoom3301
Merge pull request #99 from cowprotocol/refactoring/dogfooding-2
e9db1e4 
[SDK refactoring #2] new OrderBook API (based on swagger)
@alfetopito alfetopito mentioned this issue Aug 3, 2023
Closed
shoom3301 pushed a commit that referenced this issue Sep 23, 2024
@yvesfracari @ribeirojose
feat: sdk for CowShed hooks (#219)
f07d2d6 
* add cow shed related abi and move contracts codegen folder to common

* add initial cow shed package

* add tests to the cow-shed module

* add wip comments

* chore(examples): add local cow sdk version to cra example

* feat(examples): add generate cow shed hook calldata

* revert ethers version change

* improve bigint readability

* Add cow-shed module (#2)

* add cow shed related abi and move contracts codegen folder to common

* add initial cow shed package

* add tests to the cow-shed module

* add wip comments

* chore(examples): add local cow sdk version to cra example

* feat(examples): add generate cow shed hook calldata

* revert ethers version change

* improve bigint readability

---------

Co-authored-by: José Ribeiro <[email protected]>

* chore: add contracts deployment

* refactor: change computeProxyAddress method to proxyOf

* refactor: simplify domain of function

* chore: add deployed proxy init code

---------

Co-authored-by: José Ribeiro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matextrem matextrem

Labels
Protofire
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing unit tests cowprotocol/cow-sdk
2 participants
@anxolin @matextrem