Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(subgraph): explicitly define which networks are supported for Subgraph #195

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

shoom3301
Copy link
Contributor

Since not all networks have Subgraph support we need to explicitly define which networks have support.
To do this, I've changed type of SUBGRAPH_PROD_CONFIG and SUBGRAPH_STAGING_CONFIG.
Now the type is string | undefined, undefined means that Subgraph is not supported for the network.

@shoom3301 shoom3301 requested a review from a team January 9, 2024 12:46
@shoom3301 shoom3301 self-assigned this Jan 9, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jan 9, 2024

Coverage Status

coverage: 78.899% (-0.1%) from 79.032%
when pulling 23bc918 on feat/subgraph-optional
into a523528 on main.

Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @cowprotocol/[email protected]

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@shoom3301 shoom3301 merged commit f6251a7 into main Jan 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2024
@alfetopito alfetopito deleted the feat/subgraph-optional branch January 9, 2024 13:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants