-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump openapi #200
Merged
Merged
chore: bump openapi #200
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,92 @@ | ||
/* istanbul ignore file */ | ||
/* tslint:disable */ | ||
/* eslint-disable */ | ||
|
||
import type { Address } from './Address'; | ||
import type { AppDataHash } from './AppDataHash'; | ||
import type { BuyTokenDestination } from './BuyTokenDestination'; | ||
import type { FeePolicy } from './FeePolicy'; | ||
import type { InteractionData } from './InteractionData'; | ||
import type { OrderClass } from './OrderClass'; | ||
import type { OrderKind } from './OrderKind'; | ||
import type { SellTokenSource } from './SellTokenSource'; | ||
import type { Signature } from './Signature'; | ||
import type { TokenAmount } from './TokenAmount'; | ||
import type { UID } from './UID'; | ||
|
||
/** | ||
* A solvable order included in the current batch auction. Contains the data forwarded to solvers for solving. | ||
* | ||
*/ | ||
export type AuctionOrder = { | ||
uid: UID; | ||
/** | ||
* see `OrderParameters::sellToken` | ||
*/ | ||
sellToken: Address; | ||
/** | ||
* see `OrderParameters::buyToken` | ||
*/ | ||
buyToken: Address; | ||
/** | ||
* see `OrderParameters::sellAmount` | ||
*/ | ||
sellAmount: TokenAmount; | ||
/** | ||
* see `OrderParameters::buyAmount` | ||
*/ | ||
buyAmount: TokenAmount; | ||
/** | ||
* see `OrderParameters::feeAmount` | ||
*/ | ||
userFee: TokenAmount; | ||
/** | ||
* see `OrderParameters::validTo` | ||
*/ | ||
validTo: number; | ||
/** | ||
* see `OrderParameters::kind` | ||
*/ | ||
kind: OrderKind; | ||
/** | ||
* see `OrderParameters::receiver` | ||
*/ | ||
receiver: Address | null; | ||
owner: Address; | ||
/** | ||
* see `OrderParameters::partiallyFillable` | ||
*/ | ||
partiallyFillable: boolean; | ||
/** | ||
* Currently executed amount of sell/buy token, depending on the order kind. | ||
* | ||
*/ | ||
executed: TokenAmount; | ||
/** | ||
* The pre-interactions that need to be executed before the first execution of the order. | ||
* | ||
*/ | ||
preInteractions: Array<InteractionData>; | ||
/** | ||
* The post-interactions that need to be executed after the execution of the order. | ||
* | ||
*/ | ||
postInteractions: Array<InteractionData>; | ||
/** | ||
* see `OrderParameters::sellTokenBalance` | ||
*/ | ||
sellTokenBalance: SellTokenSource; | ||
/** | ||
* see `OrderParameters::buyTokenBalance` | ||
*/ | ||
buyTokenBalance: BuyTokenDestination; | ||
class: OrderClass; | ||
appData: AppDataHash; | ||
signature: Signature; | ||
/** | ||
* The fee policies that are used to compute the protocol fees for this order. | ||
* | ||
*/ | ||
protocolFees: Array<FeePolicy>; | ||
}; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
/* istanbul ignore file */ | ||
/* tslint:disable */ | ||
/* eslint-disable */ | ||
|
||
import type { Surplus } from './Surplus'; | ||
import type { Volume } from './Volume'; | ||
|
||
/** | ||
* Defines the ways to calculate the protocol fee. | ||
*/ | ||
export type FeePolicy = (Surplus | Volume); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
/* istanbul ignore file */ | ||
/* tslint:disable */ | ||
/* eslint-disable */ | ||
|
||
import type { Address } from './Address'; | ||
import type { CallData } from './CallData'; | ||
import type { TokenAmount } from './TokenAmount'; | ||
|
||
export type InteractionData = { | ||
target?: Address; | ||
value?: TokenAmount; | ||
/** | ||
* The call data to be used for the interaction. | ||
*/ | ||
call_data?: Array<CallData>; | ||
}; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
/* istanbul ignore file */ | ||
/* tslint:disable */ | ||
/* eslint-disable */ | ||
|
||
/** | ||
* The protocol fee is taken as a percent of the surplus. | ||
*/ | ||
export type Surplus = { | ||
factor: number; | ||
max_volume_factor: number; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Request for backed: |
||
}; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
/* istanbul ignore file */ | ||
/* tslint:disable */ | ||
/* eslint-disable */ | ||
|
||
/** | ||
* The protocol fee is taken as a percent of the order volume. | ||
*/ | ||
export type Volume = { | ||
factor: number; | ||
}; | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not getting from latest from master the openapi?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind, I'm only following the convention that was here previously.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think is nice that we use the latest. If swagger becomes autogenerated, and this uses the latest, we will notice when there's unmapped errors if we touch the lib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm almost sure I suggested to use release rather than master to have a better control/tracking of where the current version comes from.
If pointing to a branch, it's harder to tell which commit was used as a reference.
If we don't want to use a release, should we use a commit on
main
branch instead?This way the update is intentional and clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with pointing to a version, I actually think is safer and agree with it being more reproducible.
My only concern is, we won't remember to update from time to time, if this doesn't bother us on commit.
One alternative is to make a check if we use the latest version.