Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: devcontainer #203

Merged
merged 2 commits into from
Apr 2, 2024
Merged

feat: devcontainer #203

merged 2 commits into from
Apr 2, 2024

Conversation

mfw78
Copy link
Contributor

@mfw78 mfw78 commented Apr 2, 2024

This PR:

  1. Adds a devcontainer that can be used for ensuring that developers are using a consistent environment when building on cow-sdk.

@mfw78 mfw78 added the enhancement New feature or request label Apr 2, 2024
@mfw78 mfw78 requested a review from a team April 2, 2024 09:22
@mfw78 mfw78 self-assigned this Apr 2, 2024
shoom3301
shoom3301 approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@shoom3301 shoom3301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how it works, but I hope you know what you do :)

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 78.851%. remained the same
when pulling 77297d2 on devcontainer
into e5bedea on main.

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 78.851%. remained the same
when pulling 77297d2 on devcontainer
into e5bedea on main.

alfetopito
alfetopito approved these changes Apr 2, 2024
View reviewed changes
.devcontainer/devcontainer.json
Comment on lines +8 to +11
"installZsh": true,
"configureZshAsDefaultShell": true,
"installOhMyZsh": true,
"installOhMyZshConfig": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@mfw78 mfw78 merged commit d29add2 into main Apr 2, 2024
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2024
anxolin
anxolin reviewed Apr 2, 2024
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you also add something in the readme regarding this?

Also, should you include in the PR some test steps?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin left review comments

@alfetopito alfetopito alfetopito approved these changes

@shoom3301 shoom3301 shoom3301 approved these changes

Assignees

@mfw78 mfw78

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mfw78 @coveralls @alfetopito @anxolin @shoom3301