Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add arbitrum #206

Merged
merged 6 commits into from
May 3, 2024
Merged

feat: add arbitrum #206

merged 6 commits into from
May 3, 2024

Conversation

alfetopito
Copy link
Contributor

@alfetopito alfetopito commented May 1, 2024

Summary

Part of cowprotocol/cowswap#4310

Add Arbitrum

@alfetopito alfetopito self-assigned this May 1, 2024
@alfetopito alfetopito requested a review from a team May 1, 2024 17:02
Copy link

socket-security bot commented May 1, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/[email protected] Transitive: environment +6 91.1 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 57.9 kB nicolo-ribaudo
npm/@babel/[email protected] environment, filesystem, unsafe +4 1.68 MB nicolo-ribaudo
npm/@babel/[email protected] None 0 478 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 50.7 kB nicolo-ribaudo
npm/@babel/[email protected] None +5 205 kB nicolo-ribaudo
npm/@babel/[email protected] None +1 28.9 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 21.4 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 54.1 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 16.1 kB nicolo-ribaudo
npm/@babel/[email protected] None +3 167 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 51.7 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 11.4 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 1.87 MB nicolo-ribaudo
npm/@babel/[email protected] None +2 41.6 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 6.26 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 64.7 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 5.26 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 258 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 68.8 kB nicolo-ribaudo
npm/@babel/[email protected] None +3 596 kB nicolo-ribaudo
npm/@babel/[email protected] environment +1 2.51 MB nicolo-ribaudo
npm/@csstools/[email protected] None 0 43.9 kB alaguna
npm/@csstools/[email protected] None 0 16.7 kB alaguna
npm/@ethereumjs/[email protected] None 0 2.53 MB holgerd77
npm/@noble/[email protected] None 0 1.3 MB paulmillr
npm/@safe-global/[email protected] None +2 846 kB dasanra
npm/@safe-global/[email protected] None +1 2.62 MB dasanra
npm/@sindresorhus/[email protected] None 0 57.5 kB sindresorhus
npm/@testing-library/[email protected] None +3 360 kB testing-library-bot
npm/@testing-library/[email protected] environment +2 6.94 MB testing-library-bot
npm/@testing-library/[email protected] Transitive: environment +2 3.09 MB testing-library-bot
npm/@types/[email protected] None +2 52.3 kB types
npm/@types/[email protected] None 0 65.2 kB types
npm/@types/[email protected] None 0 13.8 kB types
npm/@types/[email protected] None +3 29.3 kB types
npm/@types/[email protected] None +4 521 kB types
npm/@types/[email protected] None 0 28.8 kB types
npm/@types/[email protected] None +2 193 kB types
npm/@typescript-eslint/[email protected] Transitive: environment, filesystem +6 2.29 MB jameshenry
npm/[email protected] None 0 10.4 kB jeffcarp
npm/[email protected] None 0 100 kB marijn
npm/[email protected] None 0 8.06 kB benng
npm/[email protected] environment, filesystem, shell 0 13 kB fengmk2
npm/[email protected] None 0 176 kB jessebeach
npm/[email protected] None 0 25 kB ljharb
npm/[email protected] None 0 82.1 kB ljharb
npm/[email protected] environment Transitive: eval, filesystem, shell +20 220 kB simenb
npm/[email protected] None 0 9.35 kB junderw
npm/[email protected] environment, eval, unsafe 0 632 kB esailija
npm/[email protected] None +1 34.6 kB cwmma
npm/[email protected] None 0 3.68 kB cwmma
npm/[email protected] None +1 101 kB feross
npm/[email protected] None 0 11.7 kB sindresorhus
npm/[email protected] None 0 7.95 kB cwmma
npm/[email protected] filesystem 0 11.4 kB thlorenz

🚮 Removed packages: npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@graphql-codegen/[email protected], npm/@graphql-codegen/[email protected], npm/@graphql-codegen/[email protected], npm/@graphql-codegen/[email protected], npm/@graphql-codegen/[email protected], npm/@graphql-tools/[email protected], npm/@graphql-tools/[email protected], npm/@graphql-tools/[email protected], npm/@graphql-tools/[email protected], npm/@graphql-tools/[email protected], npm/@graphql-tools/[email protected], npm/@graphql-tools/[email protected], npm/@graphql-tools/[email protected], npm/@graphql-tools/[email protected], npm/@graphql-typed-document-node/[email protected], npm/@jest/[email protected], npm/@jest/[email protected], npm/@jridgewell/[email protected], npm/@jridgewell/[email protected], npm/@jridgewell/[email protected], npm/@repeaterjs/[email protected], npm/@sinclair/[email protected], npm/@typechain/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

socket-security bot commented May 1, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: node -e "try{require('./postinstall')}catch(e){}"
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: node -e "try{require('./postinstall')}catch(e){}"

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@coveralls
Copy link
Collaborator

coveralls commented May 1, 2024

Coverage Status

coverage: 78.851%. remained the same
when pulling c17bf90 on feat/4310_add-arbitrum
into ca5a581 on main.

@@ -27,11 +27,11 @@
"prepare": "npm run build",
"prepublishOnly": "npm test && npm run lint",
"graphql:codegen": "graphql-codegen --config graphql-codegen.yml",
"swagger:codegen": " openapi --input https://raw.githubusercontent.com/cowprotocol/services/v2.252.0/crates/orderbook/openapi.yml --output src/order-book/generated --exportServices false --exportCore false",
"swagger:codegen": " openapi --input https://raw.githubusercontent.com/cowprotocol/services/varbitrum/crates/orderbook/openapi.yml --output src/order-book/generated --exportServices false --exportCore false",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will need to remember to come back here, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, every backend release we need to update it, and this is the latest

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but i thought we do tagged versions. But anyways, fine, next version we change it

@@ -47,6 +48,7 @@ export const ORDER_BOOK_PROD_CONFIG: ApiBaseUrls = {
export const ORDER_BOOK_STAGING_CONFIG: ApiBaseUrls = {
[SupportedChainId.MAINNET]: 'https://barn.api.cow.fi/mainnet',
[SupportedChainId.GNOSIS_CHAIN]: 'https://barn.api.cow.fi/xdai',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weren't these names changing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes yet afaict, just the proposal for a standardization.

@alfetopito alfetopito force-pushed the feat/4310_add-arbitrum branch from f870480 to c17bf90 Compare May 3, 2024 13:00
[SupportedChainId.MAINNET]: 'https://YOUR_ENDPOINT/mainnet',
[SupportedChainId.GNOSIS_CHAIN]: 'https://YOUR_ENDPOINT/gnosis-chain',
[SupportedChainId.GNOSIS_CHAIN]: 'https://YOUR_ENDPOINT/gnosis_chain',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As requested, your Highness.

@alfetopito alfetopito merged commit 9556d41 into main May 3, 2024
8 of 9 checks passed
@alfetopito alfetopito deleted the feat/4310_add-arbitrum branch May 3, 2024 13:39
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants