Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow changing backoff and limiter per request #208

Merged
merged 3 commits into from
May 16, 2024

Conversation

shoom3301
Copy link
Contributor

Context: https://cowservices.slack.com/archives/C0361CDG8GP/p1715853690864799?thread_ts=1715851334.267859&cid=C0361CDG8GP

In some cases we need to configure backoff or limiter per request.
For example, by default we want to use default strategy (10 retries), but for a specific case we want to use 1 retry.

To allow that I've included RequestOptions into ApiContext and added override of the parameters.

@shoom3301 shoom3301 requested a review from a team May 16, 2024 10:18
@shoom3301 shoom3301 self-assigned this May 16, 2024
…at/flexible-request-options

# Conflicts:
#	src/order-book/api.ts
@coveralls
Copy link
Collaborator

coveralls commented May 16, 2024

Coverage Status

coverage: 78.809% (-0.04%) from 78.851%
when pulling 826f410 on feat/flexible-request-options
into 3654b87 on main.

@shoom3301 shoom3301 merged commit 4368844 into main May 16, 2024
7 of 9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
@alfetopito alfetopito deleted the feat/flexible-request-options branch May 16, 2024 14:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants