Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumped version to 2.4.0 #179

Merged
merged 9 commits into from
Apr 18, 2023
Merged

Bumped version to 2.4.0 #179

merged 9 commits into from
Apr 18, 2023

Conversation

alfetopito
Copy link
Collaborator

@alfetopito alfetopito commented Apr 18, 2023 •
edited
Loading

Summary

Adding WETH on Gnosis chain
Plus updates to addToken form which are already live (once it hits develop they are active), no impact on main

Testing

  1. Add the list to cowswap and verify it loads https://raw.githubusercontent.com/cowprotocol/token-lists/814ddef95ff3c62ba8901038fc37db3d982fbc5f/src/public/CowSwap.json
  2. Check it also on tokenlists: https://tokenlists.org/token-list?url=https://raw.githubusercontent.com/cowprotocol/token-lists/814ddef95ff3c62ba8901038fc37db3d982fbc5f/src/public/CowSwap.json

alfetopito and others added 9 commits April 18, 2023 06:03
@alfetopito
Prevent spaces in token symbols (#169)
566a6cd 
* Added description about not using token symbols

* Failing validation if token symbol contains spaces
@alfetopito
Trying to fix validate symbol
a7de559
@alfetopito
Trying a ternary operator in shell to fix exit value
00e6e44
@alfetopito
Revert "Trying a ternary operator in shell to fix exit value"
72f8854 
This reverts commit 00e6e44.
@alfetopito
Revert "Trying to fix validate symbol"
78280a2 
This reverts commit a7de559.
@alfetopito
Revert "Prevent spaces in token symbols (#169)"
9a87c73 
This reverts commit 566a6cd.
@alfetopito
New attempt at validating token symbols
79f7132
@github-actions @alfetopito
[addToken] WETH to GNOSIS_CHAIN (#178)
bcf2af3 
* [addToken] GNOSIS_CHAIN/0x6A023CCd1ff6F2045C3309768eAd9E68F978f6e1

* Reverting to original image

---------

Co-authored-by: alfetopito <[email protected]>
@alfetopito
Bumped version to 2.4.0
814ddef
@alfetopito alfetopito changed the base branch from develop to main April 18, 2023 15:35
@alfetopito alfetopito self-assigned this Apr 18, 2023
@alfetopito alfetopito merged commit c7657ab into main Apr 18, 2023
@alfetopito alfetopito deleted the release/2.4.0 branch April 18, 2023 15:38
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shoom3301 shoom3301 shoom3301 approved these changes

Assignees

@alfetopito alfetopito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alfetopito @shoom3301