Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: store and use image's stop signal to stop containers #539

Merged
merged 2 commits into from
May 27, 2017

Conversation

runcom
Copy link
Member

@runcom runcom commented May 26, 2017

Update image-spec to RC6, store and use StopSignal for stopping containers.

Signed-off-by: Antonio Murdaca [email protected]

@runcom
Copy link
Member Author

runcom commented May 26, 2017

@mrunalp PTAL

@@ -589,6 +589,10 @@ func (s *Server) createSandboxContainer(ctx context.Context, containerID string,

containerImageConfig := containerInfo.Config

if containerImageConfig.Config.StopSignal != "" {
specgen.AddAnnotation("org.opencontainers.image.stopSignal", containerImageConfig.Config.StopSignal)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@runcom runcom force-pushed the stop-signal-cc branch 2 times, most recently from 9e525de to 2a72ee2 Compare May 26, 2017 16:44
@rh-atomic-bot
Copy link

0/0 passed on RHEL - Passed.
0/0 k8s node-e2e passed on RHEL - Failed.

0/0 passed on Fedora - Passed.
0/0 k8s node-e2e passed on Fedora - Failed.

0/0 passed on CentOS - Passed.
0/0 k8s node-e2e passed on CentOS - Failed.

Log - https://aos-ci.s3.amazonaws.com/kubernetes-incubator/cri-o/crio-integration-tests-prs/360/fullresults.txt

@runcom
Copy link
Member Author

runcom commented May 26, 2017

something's wrong on compilation, waiting on Travis to report fixed, CI will run soon.

@rh-atomic-bot
Copy link

60/60 passed on RHEL - Passed.
0/0 k8s node-e2e passed on RHEL - Failed.

23/24 passed on Fedora - Failed.
120/121 k8s node-e2e passed on Fedora - Failed.

60/60 passed on CentOS - Passed.
0/0 k8s node-e2e passed on CentOS - Failed.

Log - https://aos-ci.s3.amazonaws.com/kubernetes-incubator/cri-o/crio-integration-tests-prs/362/fullresults.txt

@rh-atomic-bot
Copy link

60/60 passed on RHEL - Passed.
0/0 k8s node-e2e passed on RHEL - Failed.

60/60 passed on Fedora - Passed.
120/121 k8s node-e2e passed on Fedora - Failed.

60/60 passed on CentOS - Passed.
0/0 k8s node-e2e passed on CentOS - Failed.

Log - https://aos-ci.s3.amazonaws.com/kubernetes-incubator/cri-o/crio-integration-tests-prs/363/fullresults.txt

runcom added 2 commits May 27, 2017 10:20
I don't want to see stuff like this anymore
https://aos-ci.s3.amazonaws.com/kubernetes-incubator/cri-o/crio-integration-tests-prs/360/fullresults.txt

It's basically missing the actual go build error because stdout gets
eaten somewhere by ansible I guess.

Signed-off-by: Antonio Murdaca <[email protected]>
@rh-atomic-bot
Copy link

60/60 passed on RHEL - Passed.
0/0 k8s node-e2e passed on RHEL - Failed.

23/24 passed on Fedora - Failed.
120/121 k8s node-e2e passed on Fedora - Failed.

60/60 passed on CentOS - Passed.
0/0 k8s node-e2e passed on CentOS - Failed.

Log - https://aos-ci.s3.amazonaws.com/kubernetes-incubator/cri-o/crio-integration-tests-prs/364/fullresults.txt

@runcom
Copy link
Member Author

runcom commented May 27, 2017

Well, everything's fine except the oom flaky

@mrunalp
Copy link
Member

mrunalp commented May 27, 2017

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants