server: store and use image's stop signal to stop containers #539
Conversation
|
@mrunalp PTAL |
server/container_create.go
Outdated
| @@ -589,6 +589,10 @@ func (s *Server) createSandboxContainer(ctx context.Context, containerID string, | |||
|
|
|||
| containerImageConfig := containerInfo.Config | |||
|
|
|||
| if containerImageConfig.Config.StopSignal != "" { | |||
| specgen.AddAnnotation("org.opencontainers.image.stopSignal", containerImageConfig.Config.StopSignal) | |||
There was a problem hiding this comment.
in case you're wondering why I'm using this key: https://github.com/opencontainers/image-spec/pull/492/files#diff-8aafbe2c3690162540381b8cdb157112R57
runcom
force-pushed
the
stop-signal-cc
branch
2 times, most recently
from
9e525de to
2a72ee2
Compare
|
0/0 passed on RHEL - Passed. 0/0 passed on Fedora - Passed. 0/0 passed on CentOS - Passed. |
|
|
|
60/60 passed on RHEL - Passed. 23/24 passed on Fedora - Failed. 60/60 passed on CentOS - Passed. |
|
60/60 passed on RHEL - Passed. 60/60 passed on Fedora - Passed. 60/60 passed on CentOS - Passed. |
I don't want to see stuff like this anymore https://aos-ci.s3.amazonaws.com/kubernetes-incubator/cri-o/crio-integration-tests-prs/360/fullresults.txt It's basically missing the actual go build error because stdout gets eaten somewhere by ansible I guess. Signed-off-by: Antonio Murdaca <[email protected]>
Signed-off-by: Antonio Murdaca <[email protected]>
|
60/60 passed on RHEL - Passed. 23/24 passed on Fedora - Failed. 60/60 passed on CentOS - Passed. |
|
Well, everything's fine except the oom flaky |
|
LGTM |
Update image-spec to RC6, store and use
StopSignalfor stopping containers.Signed-off-by: Antonio Murdaca [email protected]