Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invalid Not keyword resolution #258

Merged
merged 2 commits into from
Jun 4, 2021
Merged

Conversation

fmigneault
Copy link
Collaborator

@fmigneault fmigneault commented Jun 3, 2021

fix invalid Not keyword resolution for LiteralInputType which resulted into too verbose process description inputs

The missing deserialization of the resulting mapping following OpenAPI not keyword validation resulted into all fields under a literal input type to bubble up in the process description. For example, fields like data_format, mode, mimetype, workdir, etc. that come from the pywps/owslib/cwl object json conversion would be returned.

…d into too verbose process description inputs
@github-actions github-actions bot added ci/doc Issue related to documentation of the package ci/tests Tests of the package and features feature/oas Issues related to OpenAPI specifications. process/wps3 Issue related to WPS 3.x (REST-JSON) processes support labels Jun 3, 2021
@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #258 (a13dd93) into master (691c8b8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #258   +/-   ##
=======================================
  Coverage   71.80%   71.80%           
=======================================
  Files          61       61           
  Lines        9323     9323           
  Branches     1400     1400           
=======================================
  Hits         6694     6694           
  Misses       2237     2237           
  Partials      392      392           
Impacted Files Coverage Δ
weaver/wps_restapi/colander_extras.py 77.41% <100.00%> (ø)
weaver/wps_restapi/swagger_definitions.py 99.88% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 691c8b8...a13dd93. Read the comment docs.

@fmigneault fmigneault requested a review from trapsidanadir June 3, 2021 22:37
@fmigneault fmigneault merged commit 0093e24 into master Jun 4, 2021
@fmigneault fmigneault deleted the fix-not-keyword-literal-input branch June 4, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/doc Issue related to documentation of the package ci/tests Tests of the package and features feature/oas Issues related to OpenAPI specifications. process/wps3 Issue related to WPS 3.x (REST-JSON) processes support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants