Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

echidna regression test failure while upgrading truffle to 5.9.1 #1049

Closed
chenrui333 opened this issue May 20, 2023 · 4 comments
Closed

echidna regression test failure while upgrading truffle to 5.9.1 #1049

chenrui333 opened this issue May 20, 2023 · 4 comments

Comments

@chenrui333
Copy link

Looks like the default contract address is not deployable

==> /opt/homebrew/Cellar/echidna/2.1.1/bin/echidna --format text /private/tmp/echidna-test-20230520-94978-1wzi1hh
echidna: Deploying the contract 0x00a329c0648769A73afAc7F9381E08FB43dBEA72 failed (revert, out-of-gas, sending ether to an non-payable constructor, etc.):

[2023-05-20 18:20:56.70] Compiling /private/tmp/echidna-test-20230520-94978-1wzi1hh... Done! (36.216785s)
Analyzing contract: /private/tmp/echidna-test-20230520-94978-1wzi1hh/contracts/test.sol:True
/opt/homebrew/Library/Homebrew/ignorable.rb:29:in `block in raise'

relates to Homebrew/homebrew-core#131489

@chenrui333
Copy link
Author

chenrui333 commented May 20, 2023

Actually the contract deployment works with truffle 5.9.0

==> /opt/homebrew/Cellar/echidna/2.1.1/bin/echidna --format text /private/tmp/echidna-test-20230520-67224-hhaaj6
  [2023-05-20 15:59:43.25] Compiling /private/tmp/echidna-test-20230520-67224-hhaaj6... Done! (2.228798s)
  Analyzing contract: /private/tmp/echidna-test-20230520-67224-hhaaj6/contracts/test.sol:True
  [2023-05-20 15:59:45.48] Running slither on /private/tmp/echidna-test-20230520-67224-hhaaj6... Done! (0.743016s)
  [2023-05-20 15:59:49.23] [status] tests: 0/1, values: [], fuzzing: 28129/50000, cov: 92, corpus: 2
  echidna_true:  passed! 🎉
  Unique instructions: 92
  Unique codehashes: 1
  Corpus size: 2
  Seed: 4497770500591259[64](https://github.com/Homebrew/homebrew-core/actions/runs/5034489150/jobs/9029349688?pr=131502#step:3:65)
  Error: echidna: failed
  An exception occurred within a child process:
    Minitest::Assertion: Expected: 1
    Actual: 0

See Homebrew/homebrew-core#131502

@elopez
Copy link
Member

elopez commented May 21, 2023

Thanks for the report & for bringing this to our attention @chenrui333! This appears to be related to the change of default EVM version to shanghai in solc 0.8.20 & truffle 5.9.1. Explicitly specifying the previous EVM version as target (paris, see Homebrew/homebrew-core#131509) fixes the test on both truffle versions.

@chenrui333
Copy link
Author

got you, thanks for the PR!!

@ggrieco-tob
Copy link
Member

This looks fixed to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants