Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

echidna: update test #131509

Merged
merged 1 commit into from
May 21, 2023
Merged

echidna: update test #131509

merged 1 commit into from
May 21, 2023

Conversation

elopez
Copy link
Contributor

@elopez elopez commented May 21, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Echidna apparently does not yet support builds targeting Shanghai EVM. Build the test contract targeting Paris EVM version instead for the time being.

Relates to:

@github-actions github-actions bot added the haskell Haskell use is a significant feature of the PR or issue label May 21, 2023
@chenrui333 chenrui333 added the CI-no-bottles Merge without publishing bottles label May 21, 2023
Echidna apparently does not yet support builds targeting Shanghai EVM.
Build the test contract targeting Paris EVM version instead for the
time being.
@chenrui333 chenrui333 force-pushed the update-echidna-test branch from 9a705f3 to 21996b4 Compare May 21, 2023 11:21
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label May 21, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue May 21, 2023
Merged via the queue into Homebrew:master with commit 08f086a May 21, 2023
@dtrodrigues dtrodrigues mentioned this pull request May 21, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2023
Comment on lines +56 to +59
# echidna does not appear to work with 'shanghai' EVM targets yet, which became the
# default in solc 0.8.20 / truffle 5.9.1
# Use an explicit 'paris' EVM target meanwhile, which was the previous default
inreplace "truffle-config.js", %r{//\s*evmVersion:.*$}, "evmVersion: 'paris'"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-bottles Merge without publishing bottles haskell Haskell use is a significant feature of the PR or issue outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants