Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split each test group into separate files #457

Merged
merged 2 commits into from
Jun 3, 2020
Merged

split each test group into separate files #457

merged 2 commits into from
Jun 3, 2020

Conversation

incertia
Copy link
Contributor

@incertia incertia commented May 1, 2020

review should be quick and easy, the only other real change i did was add prisms to SolException. it shouldn't affect any other PRs other than #452.

@incertia incertia requested review from arcz and ggrieco-tob May 1, 2020 19:58
@incertia
Copy link
Contributor Author

incertia commented May 1, 2020

this is the first step to the testing refactor, the next step will be to fix testContract and testContract' to be more understandable by using a TestOptions parameter. testContract = testContract' defaultOptions etc.

@incertia
Copy link
Contributor Author

incertia commented May 1, 2020

semantically the only testing code i actually changed was using pmatch instead of -XLambdaCase here.

@incertia incertia merged commit 70fecc9 into master Jun 3, 2020
@incertia incertia deleted the test-refactor branch June 3, 2020 17:06
@incertia incertia mentioned this pull request Jun 4, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggrieco-tob ggrieco-tob ggrieco-tob approved these changes

@arcz arcz Awaiting requested review from arcz arcz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@incertia @ggrieco-tob