fix issue where libraries would get loaded at extreme timestamps and block numbers, also switch to the new hevm stripBytecodeMetadata #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
b8bc129 adds some intermediate hevm-0.41 version that we should aim to change before we release echidna, or do a beta release |
…block numbers, also switch to the new hevm stripBytecodeMetadata
incertia
force-pushed
the
fix-timestamps
branch
2 times, most recently
from
6d31d70 to
148d0ce
Compare
|
newer hevm has been moved to #511 and this should just aim to fix some things |
ggrieco-tob
reviewed
Sep 15, 2020
|
@incertia please take a look to the new test |
ggrieco-tob
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loadLibrarieswould use(initialTimestamp, initialBlockNumber)as the delay property, causingblock . numberandblock . timestampto be incremented way more times than desired. we introduce a newinitialVMthat takes care of all this business for us so we can just use(0, 0), as well as extend the timestamp and block number business to theRPC(multicontract, we should probably also rename this) module.hevm-0.37 contains the new
stripBytecodeMetadatathat actually works and is a copy of the version i introduced a while back, so we remove that bit of duplicated code as well.