Added explicit delay in shrinking and improved pp functions #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcz
reviewed
Nov 2, 2020
| @@ -19,6 +19,7 @@ import Echidna.Types.Signature (SolCall) | |||
| data TxCall = SolCreate ByteString | |||
| | SolCall SolCall | |||
| | SolCalldata ByteString | |||
| | NoCall | |||
There was a problem hiding this comment.
I get the semantics from the context of this PR but I think this data constructor can be confusing in future. Can we document the semantics here?
Looking further, as this is not really a call but rather other event altering the VM state maybe we could refactor that into something like:
data TemporalEvent = AddDelay
data EventType = TxCall TxCall | TemporalEvent TemporalEventThis would also eliminate the need of _ -> error "NoCall" in setupTx. This could involve a bigger refactor to make space for future expansions as setupTx and Tx type don't handle just Tx calls anymore.
There was a problem hiding this comment.
Yes, that's a reasonable idea, but yes, it will require a larger refactor, for such a small feature. This should be the only "special" event
arcz
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR allows Echidna to use a special transaction to discover during shrinking when a function called is actually useless and only the time/block delay is triggering an failure. It will also improve a little how calls are printed to make them easier to understand.