Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify slither info parsing #543

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Conversation

arcz
Copy link
Member

@arcz arcz commented Nov 9, 2020

Improved JSON parsing with shorter code and more info stored in SlitherInfo.

@arcz arcz requested review from incertia and ggrieco-tob November 9, 2020 14:50
@arcz arcz force-pushed the simplify-slither-info-parsing branch 2 times, most recently from 45084b7 to a07db5b Compare November 9, 2020 15:17
enh v = [v]

-- we loose info on what constants are in which functions
data SlitherInfo = SlitherInfo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it makes any sense we should also lens this

@arcz arcz force-pushed the simplify-slither-info-parsing branch from a07db5b to 8b4e226 Compare November 20, 2020 22:03
@arcz arcz requested a review from incertia November 20, 2020 22:28
@arcz arcz force-pushed the simplify-slither-info-parsing branch 2 times, most recently from 5a989b6 to 1c583e0 Compare February 2, 2021 13:05
@arcz arcz force-pushed the simplify-slither-info-parsing branch from 1c583e0 to 6a94f83 Compare February 2, 2021 13:11
@arcz arcz merged commit a0509af into master Feb 2, 2021
@arcz arcz deleted the simplify-slither-info-parsing branch February 2, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants